API-41234-rep-validation-include-suffix

[stiehlrod]

Summary

• Adds logic to check with and without a suffix if it exists.
• Adds tests.

Related issue(s)

• API-41234

Testing done

• New code is covered by unit tests

Screenshots

Note: Optional

What areas of the site does it impact?

modified:   modules/veteran/app/models/veteran/service/representative.rb
modified:   modules/veteran/spec/models/veteran/service/representative_spec.rb

Acceptance criteria

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No error nor warning in the console.
• Events are being sent to the appropriate logging solution
• Documentation has been updated (link to documentation)
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Feature/bug has a monitor built into Datadog (if applicable)
• If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• I added a screenshot of the developed feature

[tycol7]

looking good! some questions/suggestions on how we are handling suffixes.

[tycol7]

looks great! i think we want suffix.any? but otherwise ready to go.