Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sign-in service specific web_origins #19034

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Add sign-in service specific web_origins #19034

merged 1 commit into from
Oct 23, 2024

Conversation

rileyanderson
Copy link
Contributor

Summary

  • Add Sign-in Service specific web_origins to sign_in settings. This is for clients that only use the SiS portion of vets-api and helps keep things separated for the eventual split

Related issue(s)

Testing

  • Test SiS and SSOe auth on vets-website
  • Test SiS auth on identity-dashboard locally (optional)

What areas of the site does it impact?

web_origins, sis

Acceptance criteria

  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected

@rileyanderson rileyanderson requested a review from a team October 23, 2024 15:52
@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 15:53 Inactive
@rileyanderson rileyanderson marked this pull request as ready for review October 23, 2024 15:53
@rileyanderson rileyanderson requested review from a team as code owners October 23, 2024 15:53
emilykim13
emilykim13 previously approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@emilykim13 emilykim13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 16:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 16:53 Inactive
@rileyanderson rileyanderson marked this pull request as draft October 23, 2024 17:16
@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 17:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 17:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to sis-web-origins/main/main October 23, 2024 18:11 Inactive
@rileyanderson rileyanderson marked this pull request as ready for review October 23, 2024 19:23
@rileyanderson rileyanderson requested review from emilykim13 and a team October 23, 2024 19:30
@github-actions GitHub Actions
Copy link

Backend-review-group approval confirmed.

@rileyanderson rileyanderson merged commit a07e038 into master Oct 23, 2024
32 of 33 checks passed
@rileyanderson rileyanderson deleted the sis-web-origins branch October 23, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilykim13 emilykim13 emilykim13 approved these changes

@stevenjcumming stevenjcumming stevenjcumming approved these changes

Assignees
No one assigned
Labels
omit-backend-approval ready-for-backend-review test-passing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rileyanderson @emilykim13 @stevenjcumming @va-vfs-bot