-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sign-in service specific web_origins #19034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
labels
Oct 23, 2024
emilykim13
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 16:07
43e7c5a
to
c02fc2a
Compare
github-actions
bot
added
require-backend-approval
and removed
omit-backend-approval
labels
Oct 23, 2024
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 16:33
c02fc2a
to
078ef01
Compare
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
Oct 23, 2024
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 17:16
078ef01
to
8c738f6
Compare
github-actions
bot
added
require-backend-approval
test-passing
and removed
require-backend-approval
test-failure
labels
Oct 23, 2024
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 17:37
8c738f6
to
2b48268
Compare
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 17:58
2b48268
to
e5126ed
Compare
rileyanderson
force-pushed
the
sis-web-origins
branch
from
October 23, 2024 18:24
e5126ed
to
f21a0bf
Compare
github-actions
bot
added
require-backend-approval
ready-for-backend-review
omit-backend-approval
and removed
require-backend-approval
labels
Oct 23, 2024
emilykim13
approved these changes
Oct 23, 2024
stevenjcumming
approved these changes
Oct 23, 2024
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing
What areas of the site does it impact?
web_origins, sis
Acceptance criteria