9775 appointments openapi #19037
Merged
9775 appointments openapi #19037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
9775-appointments-openapi/main/main
kpethtel
commented
Oct 23, 2024
| @@ -44,8 +44,5 @@ data: | |||
| locationId: '938' | |||
| meta: | |||
| errors: [{source: "VA Service"}] | |||
| checkinWindow: | |||
There was a problem hiding this comment.
All of these checkin window references are deprecated.
va-vfs-bot
temporarily deployed
to
9775-appointments-openapi/main/main
kpethtel
commented
Oct 23, 2024
| upcomingAppointmentsCount: | ||
| type: number | ||
| description: The number of BOOKED, non-pending appointments in the next upcomingDaysLimit number of days. | ||
| upcomingDaysLimit: | ||
| type: number | ||
| description: The number of days into the future used for calculating upcomingAppointmentsCount. The current value is 7. | ||
| pagination: |
There was a problem hiding this comment.
We should extract pagination into a separate file because it's duplicated across several locations, but I didn't want to bloat this PR.
va-vfs-bot
temporarily deployed
to
9775-appointments-openapi/main/main
github-actions
bot
added
test-failure
test-passing
and removed
test-passing
test-failure
labels
va-vfs-bot
temporarily deployed
to
9775-appointments-openapi/main/main
kpethtel
commented
Oct 23, 2024
| @@ -41,11 +41,6 @@ data: | |||
| patient_email: null | |||
| best_time_to_call: null | |||
| friendly_location_name: null | |||
| locationId: '938' | |||
There was a problem hiding this comment.
Location id is not in our serializer. I think this may have been added when we were working on appointment scheduling, but it doesn't seem to apply to the index.
kpethtel
commented
Oct 23, 2024
| @@ -0,0 +1,30 @@ | |||
| type: object | |||
There was a problem hiding this comment.
This was previously missed.
kpethtel
commented
Oct 23, 2024
| schema: | ||
| $ref: ./schemas/Appointments.yml | ||
| description: OK | ||
| '207': |
There was a problem hiding this comment.
This was a missed case in our docs.
github-actions
bot
added
omit-backend-approval
and removed
omit-backend-approval
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds openapi schema testing for appointments and makes necessary adjustments to the schema to make it match reality.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#9775
Testing done
This is all specs and docs. No testing needed.
Screenshots
Note: Optional
What areas of the site does it impact?
Specs and docs.
Acceptance criteria
Requested Feedback