-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
9775 appointments openapi #19037
9775 appointments openapi #19037
Conversation
@@ -44,8 +44,5 @@ data: | |||
locationId: '938' | |||
meta: | |||
errors: [{source: "VA Service"}] | |||
checkinWindow: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these checkin window references are deprecated.
upcomingAppointmentsCount: | ||
type: number | ||
description: The number of BOOKED, non-pending appointments in the next upcomingDaysLimit number of days. | ||
upcomingDaysLimit: | ||
type: number | ||
description: The number of days into the future used for calculating upcomingAppointmentsCount. The current value is 7. | ||
pagination: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should extract pagination into a separate file because it's duplicated across several locations, but I didn't want to bloat this PR.
@@ -41,11 +41,6 @@ data: | |||
patient_email: null | |||
best_time_to_call: null | |||
friendly_location_name: null | |||
locationId: '938' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Location id is not in our serializer. I think this may have been added when we were working on appointment scheduling, but it doesn't seem to apply to the index.
@@ -0,0 +1,30 @@ | |||
type: object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was previously missed.
schema: | ||
$ref: ./schemas/Appointments.yml | ||
description: OK | ||
'207': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a missed case in our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Adds openapi schema testing for appointments and makes necessary adjustments to the schema to make it match reality.
Related issue(s)
department-of-veterans-affairs/va-mobile-app#9775
Testing done
This is all specs and docs. No testing needed.
Screenshots
Note: Optional
What areas of the site does it impact?
Specs and docs.
Acceptance criteria
Requested Feedback