Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

95796 Update feature toggle actor type - IVC CHAMPVA Forms #19055

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

michaelclement
Copy link
Contributor

Summary

This PR updates the actor_type for all IVC CHAMPVA + FMP forms from user to cookie_id.

This is so that the user experience will be consistent for a user for the duration of a cookie within a singler browser, regardless of their logged in status. (per this doc)

  • Updates actor type for IVC CHAMPVA/FMP form toggles

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

NA

Copy link
Contributor

@stevelong00 stevelong00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link

Backend-review-group approval confirmed.

@michaelclement michaelclement merged commit a451a6e into master Oct 24, 2024
35 checks passed
@michaelclement michaelclement deleted the update-ivc-feature-toggles-to-use-cookie_id branch October 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants