-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-19450: Creates Banner Module #19056
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally in console
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/banners/Gemfile |
Generated by 🚫 Danger |
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/banners/Gemfile |
…o their own PR due to being caught by the github check.
Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/banner_spec.rb |
Closed because some GHA's were not completing successfully that were resolved, so they appeared to be stuck in the failed state. |
Summary
Adds a new Banner module to the codebase. This will house the new banner api we are building.
Related issue(s)
department-of-veterans-affairs/va.gov-cms#19450
Testing done
Automated using RSPEC tests.
Screenshots
What areas of the site does it impact?
Banners
Acceptance criteria