Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19450: Creates Banner Module #19056

Closed
wants to merge 18 commits into from
Closed

Conversation

dsasser
Copy link
Contributor

@dsasser dsasser commented Oct 24, 2024

Summary

Adds a new Banner module to the codebase. This will house the new banner api we are building.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#19450

Testing done

Automated using RSPEC tests.

Screenshots

Screenshot 2024-10-24 at 7 32 17 AM

What areas of the site does it impact?

Banners

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link
Contributor

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally in console

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/banners/Gemfile

Copy link

github-actions bot commented Oct 24, 2024

1 Error
🚫

Modified files in db/migrate or db/schema.rb changes should be the only files checked into this PR.

File Summary

DB File(s)

  • db/schema.rb

App File(s)

  • .github/CODEOWNERS
  • Gemfile
  • Gemfile.lock
  • config/routes.rb
  • modules/banners/Gemfile
  • modules/banners/README.rdoc
  • modules/banners/Rakefile
  • modules/banners/app/models/banner.rb
  • modules/banners/banners.gemspec
  • modules/banners/bin/rails
  • modules/banners/config/routes.rb
  • modules/banners/lib/banners.rb
  • modules/banners/lib/banners/engine.rb
  • modules/banners/lib/banners/version.rb
  • modules/banners/spec/factories/banners.rb
  • modules/banners/spec/models/banner_spec.rb
  • modules/banners/spec/spec_helper.rb
  • spec/models/banner_spec.rb
  • spec/simplecov_helper.rb
  • spec/spec_helper.rb

Application code must always be backwards compatible with the DB,
both before and after migrations have been run. For more info:

Generated by 🚫 Danger

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: modules/banners/Gemfile

Copy link

Error: A file (or its parent directories) does not have a CODEOWNERS entry. Please update the .github/CODEOWNERS file and add the entry for the Offending file: spec/models/banner_spec.rb

@dsasser
Copy link
Contributor Author

dsasser commented Oct 25, 2024

Closed because some GHA's were not completing successfully that were resolved, so they appeared to be stuck in the failed state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants