95727 - Issue with data validation in submission creditorName
and spouseFullName/last
[FSR]
#19058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found out that we are erroring when validating form data that we have mutated. This PR fixes the issue (nil
creditorName
andspouseFullName/last
instead of empty string) and allows us to see what the validation issue was in the logs rather than having to guess/look up in progress forms.Summary
Fixed issue, added better logging, and added monitor for issue (not in this PR)
Default optional parameters where they are passed in as nil/null and default to ''.
You can find me on OCTO Slack at #debt-resolution
Related issue(s)
95727
Testing done
We were not checking for truthiness and passing a string, we would just pass nil/null on for
creditorName
andspouseFullName/last
I've verified the change by running the code above in rails console. We can verify again in staging
Screenshots
Note: Optional
What areas of the site does it impact?
(Describe what parts of the site are impacted andifcode touched other areas)
Acceptance criteria
Requested Feedback
(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?