Make 26-4555 no longer need an ICN to go to the SAHSHA API #19067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
require-backend-approval
test-passing
ready-for-backend-review
and removed
require-backend-approval
labels
va-vfs-bot
temporarily deployed
to
4555-always-goes-to-SAHSHA-api/main/main
rhasselle-oddball
previously approved these changes
Oct 24, 2024
rmtolmach
reviewed
Oct 24, 2024
| @@ -34,7 +34,7 @@ def submit | |||
|
|
|||
| response = if intent_service.use_intent_api? | |||
| handle_210966_authenticated | |||
| elsif form_is264555_and_should_use_lgy_api | |||
| elsif params[:form_number] == '26-4555' | |||
There was a problem hiding this comment.
Are there tests for this that you can add to or update?
There was a problem hiding this comment.
Great point! I've added a test. Thanks @rmtolmach
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
ready-for-backend-review
require-backend-approval
test-passing
labels
va-vfs-bot
temporarily deployed
to
4555-always-goes-to-SAHSHA-api/main/main
github-actions
bot
added
require-backend-approval
and removed
require-backend-approval
labels
github-actions
bot
added
require-backend-approval
ready-for-backend-review
and removed
require-backend-approval
ready-for-backend-review
test-failure
labels
rmtolmach
approved these changes
Oct 25, 2024
|
Backend-review-group approval confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR sends 26-4555s to the SAHSHA API regardless of whether the user has an ICN or not. It should never go down the Benefits Intake API path.
Related issue(s)
https://github.com/orgs/department-of-veterans-affairs/projects/1443/views/3?sliceBy%5Bvalue%5D=Thrillberg&pane=issue&itemId=84586637&issue=department-of-veterans-affairs%7CVA.gov-team-forms%7C1789