API-41395-rep-validation-suffix-II #19071
Open
+24
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all_for_user in poa_verification and target_veteran. Removes get_suffixes method in representative, and adds suffix lookup using the identity suffix.
va-vfs-bot
temporarily deployed
to
API-41395-rep-validation-suffix-II/main/main
stiehlrod
changed the title
tycol7
reviewed
Oct 24, 2024
modules/claims_api/app/controllers/concerns/claims_api/target_veteran.rb
Outdated
Show resolved
Hide resolved
modules/claims_api/app/controllers/concerns/claims_api/user_identifier.rb
Outdated
Show resolved
Hide resolved
modules/claims_api/app/controllers/concerns/claims_api/poa_verification.rb
Outdated
Show resolved
Hide resolved
github-actions
bot
added
omit-backend-approval
ready-for-backend-review
and removed
omit-backend-approval
labels
github-actions
bot
added
omit-backend-approval
and removed
ready-for-backend-review
omit-backend-approval
labels
tycol7
requested changes
Oct 25, 2024
Comment on lines
+116
to
+124
| representatives = if suffix.present? | ||
| last_and_suffix = "#{last_name} #{suffix.downcase}" | ||
|
|
||
| representatives = where('lower(first_name) = ? AND lower(last_name) = ?', first_name&.downcase, | ||
| last_name&.downcase) | ||
| where('lower(first_name) = ? AND lower(last_name) = ?', first_name&.downcase, | ||
| last_and_suffix&.downcase) | ||
| end | ||
| if representatives.blank? | ||
| where('lower(first_name) = ? AND lower(last_name) = ?', first_name&.downcase, | ||
| last_name&.downcase) |
There was a problem hiding this comment.
We aren't returning anything if we find representatives with a suffix (i.e., the function will return nil if representatives is not blank). Should we add a return statement either after line 121 or 124 5?
Comment on lines
73
to
80
| it 'can find a user with a suffix' do | ||
| expect(Veteran::Service::Representative.all_for_user( | ||
| first_name: identity.first_name, | ||
| last_name: "#{identity.last_name} III", | ||
| last_name: identity.last_name, | ||
| suffix: 'Jr', | ||
| poa_code: 'A1Q' | ||
| ).first.poa_codes).to include('A1Q') | ||
| end |
There was a problem hiding this comment.
Should we create a test user with a suffix in their last name, so we can exercise the case where we find a user by their suffix? This test will strip the suffix (Jr) because there is no lincoln jr in the database, which conceals the error in our return logic.
FonzMP
reviewed
Oct 25, 2024
Comment on lines
83
to
+84
| last_name: @current_user.last_name, | ||
| middle_initial:) | ||
| middle_initial:, suffix:) |
There was a problem hiding this comment.
we could keep the logic here and not modify the all_for_user method at all. we can just do the existing lookup
first_name: @current_user.first_name,
last_name: @current_user.last_name
and if we don't find anything we can do something like
last_with_suffix = [@current_user.last_name, @current_user.suffix].compact_blank.join(' ')
first_name: @current_user.first_name,
last_name: last_with_suffix
There was a problem hiding this comment.
actually seeing undefined local variable or method 'suffix' in local
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
Acceptance criteria
Requested Feedback
Ideas on how to better test the suffix lookup.