Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated VAProfile::V2::Address to VAProfile::V3::Address #19073

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

RachalCassity
Copy link
Member

@RachalCassity RachalCassity commented Oct 24, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

According to VaProfile Address Validation docs, AddressValidation Api V3 must be used when using ContactInformation API v2.

Previously in the ContactInformation upgrade, VaProfile::Address V2 was created. Since AddressValidation api is upgrading to V3, VAProfile Address V2 was changed to V3

Screenshot 2024-10-24 at 2 28 44 PM

Related issue(s)

Testing done

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

LindseySaari
LindseySaari previously approved these changes Oct 24, 2024
@RachalCassity RachalCassity enabled auto-merge (squash) October 24, 2024 20:01
@RachalCassity RachalCassity merged commit aaedff4 into master Oct 24, 2024
25 checks passed
@RachalCassity RachalCassity deleted the rcassity-v3-address branch October 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants