Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DBEX] log and monitor form 4142 failure email events #19102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

freeheeling
Copy link
Contributor

Summary

  • This work is behind a feature toggle (flipper): YES/NO
  • (Summarize the changes that have been made to the platform)
  • (If bug, how to reproduce) N/A
  • (What is the solution, why is this the solution?)
    • Logs messages identified as silent failures
    • Increments metrics to capture an issue
    • Supports logging and metrics requirements set by VA stakeholders
  • (Which team do you work for, does your team own the maintenance of this component?)
    • Disability Benefits Experience Team 2 (dBeX Carbs 🥖), which owns maintenance of all files in this PR
  • (If introducing a flipper, what is the success criteria being targeted?) N/A

Related issue(s)

Testing done

  • New code is covered by unit tests

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

  • Impacts logging and metrics data recorded in Datadog

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disability-compensation Label used for Pull Requests that impact Disability Compensation claims (526EZ) disability-experience To manage benefits disability claims experience. ready-for-backend-review require-backend-approval test-passing zero-silent-failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants