Chart replica count on the deployment metrics page - #337
Merged
Conversation
Plot deployment.metrics.replica after Memory. Hide the panel for Static and CronJob, which have no k8s Deployment.
|
Preview deleted (PR closed). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Replicas chart to
/deployment/metrics, sourced fromdeployment.metrics.replica.clearFirstblanks replica on deployment switch so the previous line cannot leakDepends on deploys-app/apiserver#251 serving the field and deploys-app/collector#21 writing points. Empty until collector has been up for the selected window.
Test plan
bun lint/bun checktests/deployment.spec.js(Replicas heading on WebService, absent on Static)