deployment: align list status pills with the detail page - #338
Open
acoshift wants to merge 1 commit into
Open
Conversation
The deployments list labeled pending as "Deploying" and error as "Failed" (with different tones) while the detail header used "Pending" / "Error". Share one helper so both surfaces stay in lockstep. Prompter: ACS
Preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Deployments list used different status copy than the deployment detail header (
Deploying/FailedvsPending/Error, plus mismatched tones for pending, deleting, and cancelled). Clicking through a row made the status look like it had changed.Both pages now share
deploymentStatusPillinsrc/lib/deployment/status.ts, so the list shows the same labels and tones as the detail page:A healthy running deployment still has no pill — the icon next to the name already carries that signal, same as detail.
Live pod-readiness on the list icon is unchanged:
deployment.liststill omits the signedstatusUrlJWT (list-field-scoping), so the list icon resolves from storedaction/statuswithout polling. The detail page continues to poll.Screenshots
Detail page (unchanged labels — source of truth):
Test plan
bun lintandbun check/deploymentand confirm Pending / Error / Paused / Deleting / Cancelled match the matching detail pageRequested via Grok Work
Prompter: ACS