Icon Component 생성 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sumi-0011
requested review from
woobottle,
wade3420 and
JUNOSHON
as code owners
wade3420
approved these changes
Dec 2, 2023
| export default function Icon({ name, ...props }: Props) { | ||
| switch (name) { | ||
| case 'left-arrow': | ||
| return <LeftArrowIcon {...props} />; |
There was a problem hiding this comment.
나중에 디자인 시스템 나오면 size도 타입관리하면 좋을듯!
There was a problem hiding this comment.
디자인 시스템이 나오면 수정할 수 있게 이슈에 추가해둘게여
| <svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg" {...props}> | ||
| <path | ||
| d="M13.7139 17.4273L6.43555 10.149L13.7139 2.87012" | ||
| stroke={props.color ?? '#B0B8C1'} |
There was a problem hiding this comment.
컬러변경 굿...
마이너) svg 마다 defaultcolor 가 다르게 존재할까요?
woobottle
reviewed
Dec 2, 2023
2 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
# Conflicts: # src/components/Header.tsx # src/styled-system/tokens/tokens.d.ts # src/styled-system/types/prop-type.d.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
Icon Component 생성
🎉 변경 사항
LeftArrowIcon컴포넌트가 있지만, 이것이 아닌 ` 를 이용해 import 해오는 방식을 의도하였습니다.🙏 여기는 꼭 봐주세요!
LeftArrowIcon과 같이{...props}를 꼭 넣어주어야 합니다.사용 방법
/src/component/Icon폴더에 해당 아이콘 svg Component를 만들어주세요 (/src/component/Icon/LeftArrowIcon.tsx참고)/src/component/Icon/index.tsx에서 IconType에 해당 아이콘을 식별할 name을 추가해주세요. (ex,left-arrow)/src/component/Icon/index.tsx의 switch return문 안에 밑과 같이 해당 아이콘을 추가해주세요.📚 참고