fix: deletebyId로 변경 (#71)

depromeet · Jul 19, 2023 · 42bd211 · 42bd211
1 parent 07c447a
commit 42bd211
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/oversweet-api/src/main/java/com/depromeet/oversweet/record/controller/RecordController.java b/oversweet-api/src/main/java/com/depromeet/oversweet/record/controller/RecordController.java
@@ -50,7 +50,7 @@ public ResponseEntity<DataResponse<DrinkRecordSaveResponse>> saveDrinkRecord(
     }
 
     @Operation(summary = "마신 음료 삭제", description = "유저가 마신 음료를 삭제할 수 있는 기능입니다.")
-    @ApiResponses(@ApiResponse(responseCode = "201", description = "음료 기록 삭제 성공"))
+    @ApiResponses(@ApiResponse(responseCode = "200", description = "음료 기록 삭제 성공"))
     @SecurityRequirement(name = "accessToken")
     @DeleteMapping("/drink/{drinkId}")
     public ResponseEntity<MessageResponse> deleteDrinkRecord(

diff --git a/...weet-api/src/main/java/com/depromeet/oversweet/record/service/DrinkRecordSaveService.java b/...weet-api/src/main/java/com/depromeet/oversweet/record/service/DrinkRecordSaveService.java
@@ -66,8 +66,8 @@ public void deleteDrinkRecord(final Long memberId, final Long drinkId) {
 
         final DrinkEntity findDrink = findDrinkRepository.findDrinkById(drinkId);
 
-        final RecordEntity findRecord = findRecordsRepository.findRecordByMemberIdAndDrinkId(memberId, drinkId);
+        final RecordEntity findRecord = findRecordsRepository.findRecordByMemberIdAndDrinkId(findMember.getId(), findDrink.getId());
 
-        deleteRecordRepository.deleteRecordByMemberIdAndDrinkId(memberId, drinkId);
+        deleteRecordRepository.deleteById(findRecord.getId());
     }
 }
diff --git a/...rc/main/java/com/depromeet/oversweet/domain/record/repository/DeleteRecordRepository.java b/...rc/main/java/com/depromeet/oversweet/domain/record/repository/DeleteRecordRepository.java
@@ -1,5 +1,5 @@
 package com.depromeet.oversweet.domain.record.repository;
 
 public interface DeleteRecordRepository {
-    void deleteRecordByMemberIdAndDrinkId(Long memberId, Long drinkId);
+    void deleteById(Long recordId);
 }
diff --git a/...ain/java/com/depromeet/oversweet/domain/record/repository/DeleteRecordRepositoryImpl.java b/...ain/java/com/depromeet/oversweet/domain/record/repository/DeleteRecordRepositoryImpl.java
@@ -10,9 +10,10 @@ public class DeleteRecordRepositoryImpl implements DeleteRecordRepository{
 
     private final RecordJpaRepository recordJpaRepository;
 
+
     @Override
     @Transactional
-    public void deleteRecordByMemberIdAndDrinkId(final Long memberId, final Long drinkId) {
-        recordJpaRepository.deleteByMemberIdAndDrinkId(memberId, drinkId);
+    public void deleteById(final Long recordId) {
+        recordJpaRepository.deleteById(recordId);
     }
 }
diff --git a/...n/src/main/java/com/depromeet/oversweet/domain/record/repository/RecordJpaRepository.java b/...n/src/main/java/com/depromeet/oversweet/domain/record/repository/RecordJpaRepository.java
@@ -27,6 +27,4 @@ List<RankingDrink> findTop3PopularDrinksByFranchiseIdAndBetweenDates(
             Pageable pageable);
 
     Optional<RecordEntity> findByMemberIdAndDrinkId(Long memberId, Long drinkId);
-
-    void deleteByMemberIdAndDrinkId(Long memberId, Long drinkId);
 }