✨ [Feature] 마신 음료에 대한 당 기록 기능을 구현했어요. #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Comment on lines
8
to
14
| @Builder | ||
| public record DrinkRecordSaveRequest( | ||
|
|
||
| @NotNull | ||
| @Schema(description = "음료 ID", example = "1") Long id, | ||
|
|
||
| @NotNull |
There was a problem hiding this comment.
Notion 명세서에서는 drinkId로 나와있는데 통일하면 좋을것 같아요~
Comment on lines
+18
to
+21
| @NotNull | ||
| @Min(0) | ||
| @Schema(description = "1잔 기준 최종 섭취 당 함량", example = "10") Integer intakeSugar | ||
|
|
There was a problem hiding this comment.
해당 부분도 Notion 에는 finalSugar 로 나와있네요~
There was a problem hiding this comment.
아 넵 노션에 response 만 수정하고 이 부분을 놓쳤네요.
알려주셔서 감사합니다!
There was a problem hiding this comment.
id 는 drinkId 가 더 직관적인 것 같아서 이렇게 수정했고, 섭취한 당의 경우 RecordEntity 의 필드값과 통일하는 것이 좋을듯 하여 intakeSugar 로 변경했습니다.
LeeJejune
approved these changes
Jul 7, 2023
Comment on lines
43
to
52
| @Override | ||
| @Transactional(readOnly = true) | ||
| public RecordEntity findRecordById(Long id) { | ||
| return queryFactory.selectFrom(recordEntity) | ||
| .join(recordEntity.drink, drinkEntity).fetchJoin() | ||
| .join(recordEntity.drink.franchise, franchiseEntity).fetchJoin() | ||
| .where(recordEntity.member.id.eq(id)) | ||
| .fetchOne(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Optional 처리는 필요가 없을까요??
Suggested change
| @Override | |
| @Transactional(readOnly = true) | |
| public RecordEntity findRecordById(Long id) { | |
| return queryFactory.selectFrom(recordEntity) | |
| .join(recordEntity.drink, drinkEntity).fetchJoin() | |
| .join(recordEntity.drink.franchise, franchiseEntity).fetchJoin() | |
| .where(recordEntity.member.id.eq(id)) | |
| .fetchOne(); | |
| } | |
| } | |
| @Override | |
| @Transactional(readOnly = true) | |
| public Optional<RecordEntity> findRecordById(Long id) { | |
| RecordEntity recordEntity = queryFactory.selectFrom(QRecordEntity.recordEntity) | |
| .join(QRecordEntity.recordEntity.drink, QDrinkEntity.drinkEntity).fetchJoin() | |
| .join(QRecordEntity.recordEntity.drink.franchise, QFranchiseEntity.franchiseEntity).fetchJoin() | |
| .where(QRecordEntity.recordEntity.member.id.eq(id)) | |
| .fetchOne(); | |
| return Optional.ofNullable(recordEntity); | |
| } | |
There was a problem hiding this comment.
넵넵 당장은 비즈니스 로직에 사용하지 않지만 추후 활용을 위해 Optional 처리를 해주는 것이 좋을 것 같습니다.
수정하겠습니다!
soochangoforit
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗️관련 이슈번호
Close #41
⚙️ 어떤 기능을 개발했나요?
🙋🏻 어떤 부분에 집중하여 리뷰해야 할까요?