Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

πŸš‘ [Hotfix] 필터링 쑰건에 따라 음료 λͺ©λ‘ 쑰회λ₯Ό ν•  λ•Œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ 없을 경우 ν•΄λ‹Ή 데이터λ₯Ό μ œμ™Έν•˜λ„λ‘ μˆ˜μ •ν–ˆμ–΄μš”. #75

Merged
merged 1 commit into from
Jul 24, 2023
Merged

πŸš‘ [Hotfix] 필터링 쑰건에 따라 음료 λͺ©λ‘ 쑰회λ₯Ό ν•  λ•Œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ 없을 경우 ν•΄λ‹Ή 데이터λ₯Ό μ œμ™Έν•˜λ„λ‘ μˆ˜μ •ν–ˆμ–΄μš”. #75

merged 1 commit into from
Jul 24, 2023

Conversation

parkje0927
Copy link
Collaborator

❗️관련 이슈번호

CloseΒ #74

βš™οΈ μ–΄λ–€ κΈ°λŠ₯을 κ°œλ°œν–ˆλ‚˜μš”?

  • ν”„λžœμ°¨μ΄μ¦ˆ ID, 음료 μΉ΄ν…Œκ³ λ¦¬, μ •λ ¬ 쑰건에 따라 음료 λͺ©λ‘ 쑰회 μ‹œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ μ—†λŠ” 음료 λ°μ΄ν„°μ˜ κ²½μš°λŠ” μ œμ™Έν•˜λ„λ‘ 둜직 μˆ˜μ •

πŸ™‹πŸ» μ–΄λ–€ 뢀뢄에 μ§‘μ€‘ν•˜μ—¬ 리뷰해야 ν• κΉŒμš”?

  • Optional 둜 데이터 κ°€μ Έμ™€μ„œ isPresent 둜 쑴재 μ—¬λΆ€ 확인 ν›„ 데이터λ₯Ό λ„£μ—ˆμ–΄μš”.

@parkje0927 parkje0927 added ⭐ Refactoring μ½”λ“œ λ‚΄λΆ€μ μœΌλ‘œ μž‘λ™ν•˜λŠ” 방식을 λ³€κ²½ν•©λ‹ˆλ‹€. Cleanupκ³ΌλŠ” λ‹€λ¦…λ‹ˆλ‹€. πŸŒ·μ •ν˜„πŸŒ· λ‹΄λ‹Ήμž : μ •ν˜„ πŸ›  Fix 버그λ₯Ό μˆ˜μ •ν•©λ‹ˆλ‹€. labels Jul 21, 2023
@parkje0927 parkje0927 self-assigned this Jul 21, 2023
@parkje0927 parkje0927 changed the title πŸš‘ [Hotfix] 필터링 쑰건에 따라 음료 λͺ©λ‘μ„ μ‘°νšŒν•  λ•Œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ μ—†λŠ” 경우 μ œμ™Έν•˜λ„λ‘ λ‘œμ§μ„ μˆ˜μ •ν–ˆμ–΄μš”. πŸš‘ [Hotfix] 필터링 쑰건에 따라 음료 λͺ©λ‘ 쑰회λ₯Ό ν•  λ•Œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ 없을 경우 ν•΄λ‹Ή 데이터λ₯Ό μ œμ™Έν•˜λ„λ‘ μˆ˜μ •ν–ˆμ–΄μš”. Jul 21, 2023
@github-actions
Copy link

Test Results

29 tests   29 βœ”οΈβ€ƒβ€ƒ3s ⏱️
17 suitesβ€ƒβ€ƒβŸβ€„0 πŸ’€
17 filesβ€„β€‚β€ƒβ€ƒβŸβ€„0 ❌

Results for commit d734cf4.

@parkje0927 parkje0927 linked an issue Jul 21, 2023 that may be closed by this pull request
[Hotfix] 필터링 쑰건에 따라 음료 λͺ©λ‘ 쑰회λ₯Ό ν•  λ•Œ κ°€μž₯ μž‘μ€ μ‚¬μ΄μ¦ˆκ°€ 없을 경우 ν•΄λ‹Ή 데이터λ₯Ό μ œμ™Έν•˜λ„λ‘ μˆ˜μ •ν•΄μš”. #74
Closed
1 task
soochangoforit
soochangoforit approved these changes Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@soochangoforit soochangoforit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parkje0927 parkje0927 merged commit bce1daf into develop Jul 24, 2023
3 checks passed
@parkje0927 parkje0927 deleted the hotfix/#74 branch July 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soochangoforit soochangoforit soochangoforit approved these changes

@LeeJejune LeeJejune Awaiting requested review from LeeJejune

Assignees

@parkje0927 parkje0927

Labels
⭐ Refactoring μ½”λ“œ λ‚΄λΆ€μ μœΌλ‘œ μž‘λ™ν•˜λŠ” 방식을 λ³€κ²½ν•©λ‹ˆλ‹€. Cleanupκ³ΌλŠ” λ‹€λ¦…λ‹ˆλ‹€. πŸŒ·μ •ν˜„πŸŒ· λ‹΄λ‹Ήμž : μ •ν˜„ πŸ›  Fix 버그λ₯Ό μˆ˜μ •ν•©λ‹ˆλ‹€.
Projects
None yet
Milestone
No milestone
2 participants
@parkje0927 @soochangoforit