feat: email 전송 api 변경 #205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IW-MOON
force-pushed
the
feature/195-improve-mail-api
branch
from
805e1d1
to
ff55e08
Compare
IW-MOON
force-pushed
the
feature/195-improve-mail-api
branch
from
ff55e08
to
1afaab3
Compare
|
SonarCloud Quality Gate failed. |
junhaesung
reviewed
Apr 25, 2023
module-api/build.gradle
Outdated
| @@ -13,6 +13,7 @@ dependencies { | |||
| implementation("io.springfox:springfox-swagger2:2.9.2") | |||
|
|
|||
| implementation "com.amazonaws:aws-java-sdk-s3:${awsJavaSdkVersion}" | |||
| implementation 'com.amazonaws:aws-java-sdk-ses:1.12.188' | |||
There was a problem hiding this comment.
library 버전을 상수로 선언해서 사용하면 좋을 것 같습니다.
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class AwsSesConfig { |
There was a problem hiding this comment.
메일 발송은 배치나 어드민에서도 사용할 수 있는 기능이어서, domain 모듈에 추가되어도 좋을 것 같습니다.
| @@ -23,5 +23,9 @@ cloud: | |||
| s3: | |||
| connection-timeout: 1000 | |||
| request-timeout: 3000 | |||
| ses: | |||
| access-key: ENC(DB73NBzZBXtuco5qOP1/jtb+hE69JqfkbcuiM43tPG9sWNms0P+pqFaYc3gsAauMKMtI7Uz3JyOOIqztitWLcA==) | |||
There was a problem hiding this comment.
dev, prod 의 aws 계정이 각각 다른데 같은 키를 사용하나요? 환경별로 분리하는게 좋을 것 같아서요.
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class AwsSesService { |
There was a problem hiding this comment.
특정 벤더나 구현에 의존하는 구조보다는EmailService 등의 인터페이스를 선언하고, AwsSesService, GoogleSmtpService 등으로 각각의 구현체를 관리하는게 좋을 것 같습니다.
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌Linked Issues
✏Change Details
기존 : 5초 가량 소요
현재 : 0.5초 가량 소요
💬Comment
📑References
✅Check List