Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support portforwarding over websocket #2894

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: support portforwarding over websocket #2894

wants to merge 2 commits into from

Conversation

lsjostro
Copy link

fixes #2619

Falls back to SPDY if not supported.

derailed
derailed requested changes Sep 29, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsjostro Nice enhancement. Thank you for this update!

internal/dao/port_forwarder.go Outdated Show resolved Hide resolved
@derailed derailed added enhancement New feature or request needs-tlc Pr needs additional updates labels Sep 29, 2024
@lsjostro
Copy link
Author

Replicating the implementation of kubectl. https://github.com/kubernetes/kubectl/blob/master/pkg/cmd/portforward/portforward.go#L145. User can then decide to disable Websockets by setting the env var KUBECTL_PORT_FORWARD_WEBSOCKETS to false. (making it compatible with kubectl).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed requested changes

@kivra-joarod kivra-joarod kivra-joarod approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request needs-tlc Pr needs additional updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abbility to override exec and portforward commands - SPDY deprecation
3 participants
@lsjostro @derailed @kivra-joarod