Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve configurability and make redis optional #5

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

wenzowski
Copy link

This is a quick proof of concept that depends on unreleased code, but could be merged following release of next Derby & Racer alphas if the addition of convict doesn't bother anyone.

The tarballs in package.json are currently tags of derby & racer master. They're there because c9.io can't resolve git locations right now.

Environment defaults proposed do not represent strong opinions, but just examples.

@wenzowski
Copy link
Author

Note to self: c9.io is a giant pain in the ass. Just use Codio.

@wenzowski
Copy link
Author

Also, this pull doesn't completely remove redis until @josephg finishes extracting the RedisDriver from livedb

@wenzowski
Copy link
Author

Working with all examples as of derbyjs/derby-examples#44.

Would be great if @nateps or whoever is currently deploying the examples repo could chime in on whether the hosted demos should continue to use redis. If yes, I can resurrect the $REDIS_ENABLED toggle and remove pinned sha1s, and this is good for merge (if you don't think the mozilla config too adds too much extra weight–it's only ~400 lines).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant