Fix breaking change in types introduced by ValueCallback
#308
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of the
ValueCallback
type in #305 inadvertently introduced a breaking change in the types.It adds an additional constraint that the passed-in callback function must also expect
null
as a possible value for theerr
parameter in addition toError
andundefined
whereas theErrorCallback
type does not.I don't believe
null
is a possible return value for theerr
parameter based on the previous code so suggest removing thenull
from the union type forerr
inValueCallback
so that it matchesErrorCallback