minor cleanup to skip needless array copy in continuum objective

desihub · Sep 2, 2024 · 7ced18f · 7ced18f
1 parent 7f36418
commit 7ced18f
Showing 1 changed file with 6 additions and 10 deletions.
diff --git a/py/fastspecfit/continuum.py b/py/fastspecfit/continuum.py
@@ -831,8 +831,6 @@ def _stellar_objective(self, params, templateflux,
             vdisp         = None
             templatecoeff = params[1:]
 
-        # FIXME: write results directly into resid array instead of
-        # allocating new
         fullmodel = self.build_stellar_continuum(
             templateflux, templatecoeff,
             ebv=ebv, vdisp=vdisp, conv_pre=conv_pre,
@@ -857,17 +855,15 @@ def _stellar_objective(self, params, templateflux,
         if synthspec:
             modelflux = self.continuum_to_spectroscopy(fullmodel)
             spec_resid = resid[:resid_split]
-            spec_resid[:]  = specflux
-            spec_resid    -= modelflux
-            spec_resid    *= specistd
-
+            np.subtract(modelflux, specflux, spec_resid)
+            spec_resid *= specistd
+
         if synthphot:
             modelflam = self.continuum_to_photometry(fullmodel)
             phot_resid = resid[resid_split:]
-            phot_resid[:] = objflam
-            phot_resid   -= modelflam
-            phot_resid   *= objflamistd
-
+            np.subtract(modelflam, objflam, phot_resid)
+            phot_resid *= objflamistd
+
         return resid