New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

review the handling of IGM attenuation #123

Closed

moustakas opened this issue Apr 30, 2023 · 3 comments

Member

moustakas commented Apr 30, 2023

Related ticket: desihub/redrock#237

Member Author

moustakas commented Jul 6, 2023

eazy has a nice (MIT-licensed) implementation of the Inoue et al. 2014 (https://arxiv.org/pdf/1402.0677.pdf) mean intergalactic attenuation--
https://github.com/gbrammer/eazy-py/blob/master/eazy/photoz.py#L2671-L2678

Member Author

moustakas commented Jul 23, 2023

And here's another implementation from Becker+13--
https://github.com/MJTemple/qsogen/blob/main/qsosed.py#L524-L562

Next step is to compare these various implementations and choose one.

This was referenced Jul 24, 2023

treatment of IGM absorption is incorrect desihub/redrock#237

Closed

update IGM attenuation model #136

Merged

Member Author

moustakas commented Jul 25, 2023

Done in #136.

moustakas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment