Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update IGM attenuation model #136

Merged
merged 4 commits into from
Jul 25, 2023
Merged

update IGM attenuation model #136

merged 4 commits into from
Jul 25, 2023

Conversation

moustakas
Copy link
Member

Address #123 by switching to the Inoue+14 IGM attenuation coefficients which include DLAs and Lyman-limit systems.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5657121688

  • 74 of 93 (79.57%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 50.797%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/continuum.py 74 93 79.57%
Totals Coverage Status
Change from base Build 5656455960: 0.4%
Covered Lines: 2295
Relevant Lines: 4518

💛 - Coveralls

@moustakas
Copy link
Member Author

The differences are ~negligible as far as the modeling is concerned, but the new coefficients are definitely more complete / correct.

Fuji/v2.0:

Screenshot 2023-07-25 at 9 22 46 AM

this branch:

fastspec /global/cfs/cdirs/desi/spectro/redux/fuji/healpix/sv3/dark/91/9151/redrock-sv3-dark-9151.fits --targetids 39632981379255270 -o fastspec.fits
fastspecfit-qa fastspec.fits
Screenshot 2023-07-25 at 9 24 05 AM

@moustakas moustakas merged commit a33514c into main Jul 25, 2023
@moustakas moustakas deleted the igm-attenuation branch July 25, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants