fix(next-plugin): prevent incomplete Turbopack production CSS - #633
Merged
Conversation
Contributor
Changepacks@devup-ui/wasm@1.0.75 → 1.0.76 - bindings/devup-ui-wasm/package.jsonPatch
@devup-ui/bun-plugin@1.0.12 → 1.0.13 - packages/bun-plugin/package.jsonPatch
@devup-ui/components@0.1.50 → 0.1.51 - packages/components/package.jsonPatch
@devup-ui/next-plugin@1.0.80 → 1.0.81 - packages/next-plugin/package.jsonPatch
@devup-ui/plugin-utils@1.0.10 → 1.0.11 - packages/plugin-utils/package.jsonPatch
@devup-ui/react@1.0.37 → 1.0.38 - packages/react/package.jsonPatch
@devup-ui/reset-css@1.0.24 → 1.0.25 - packages/reset-css/package.jsonPatch
@devup-ui/rsbuild-plugin@1.0.58 → 1.0.59 - packages/rsbuild-plugin/package.jsonPatch
@devup-ui/vite-plugin@1.0.64 → 1.0.65 - packages/vite-plugin/package.jsonPatch
@devup-ui/webpack-plugin@1.0.63 → 1.0.64 - packages/webpack-plugin/package.jsonPatch
|
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Archibald1948
pushed a commit
to Archibald1948/devup-ui
that referenced
this pull request
Aug 24, 2026
The landing app is the repository's only real-scale acceptance target, and migrating it to vinext left `@devup-ui/next-plugin`'s Turbopack production CSS path with no e2e coverage at all. That path's last regression (dev-five-git#633) only reproduced across a 64-route build's extraction waves, so a toy app cannot replace it. Build the same sources with both bundlers and run the same 128 assertions and the same screenshot baselines against each artifact. vinext still produces the deployed output; the Next build is CI-only. - replace `import.meta.glob` demo discovery with a barrel generated by `script.js`, so the demo graph is statically visible to Turbopack and Vite alike instead of to only one of them - resolve the artifact root and the not-found manifest from LANDING_BUILD_MODE, and teach the static server Next's nested segment-cache payload layout - restore the Next toolchain behind `build:next`, which drops `deploymentId` (Next reads it as skew protection and hard-navigates when a static host cannot echo it) and skips the vinext-only RSC transport - give the local-asset sweep a stated budget and a bounded request pool; it takes ~4s alone but starved past 60s against the route-render tests - run the Next pair in a parallel `landing-next-e2e` job Verified locally, 128/128 in all four combinations: vinext and Next, each with default and DEVUP_SINGLE_CSS=1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@devup-ui/reset-csssingleCssmodes@devup-ui/next-pluginand@devup-ui/plugin-utilsRoot cause
The coordinator treated a quiet extraction window as a Turbopack compilation-complete signal. A CSS request could arrive between source-loader waves and freeze an incomplete snapshot. This scheduling race affects both CSS modes;
singleCss: trueexposed it consistently because the first shared stylesheet was missing the reset CSS layer, includingbox-sizing: border-box.The initial route-closure prewarm removed the late app-loader race, but the reset package is compiled from outside the app
srcdirectory and therefore was still absent from that set. Production prewarming now includes every extractable app source candidate and accepted external package entry using the same WASM filename and options as loader-time extraction. Loader extraction remains idempotent, while development behavior is unchanged.Failed run: https://github.com/dev-five-git/devup-ui/actions/runs/32644170599/job/97205722867
Passing run: https://github.com/dev-five-git/devup-ui/actions/runs/32650834331
Follow-up to #399.
Verification
singleCss: falsesingleCss: true