feat(device): add iOS 27 and the iPhone 17 family - #131
Merged
Conversation
Mirrors devicecloud-dev/dcd, where iOS 27 and iphone-17/-pro/-pro-max ship behind the IOS_27 rollout gate (on for dev, off in production until the fleet carries a 27 runtime). Nothing here needs gating. The flag descriptions and `cloud.ts` validation derive from these enums, so the CLI offers the values and the API's compatibility matrix is what actually accepts or rejects them — a user who asks for iOS 27 against production gets "iOS version '27' is not supported for device ...", which is the right error. `src/utils/compatibility.ts` already fetches the live matrix from GET /results/compatibility/data, so `dcd list devices` tracks the gate without a release. schema.types.ts regenerated from the API's swagger.json; the only delta is the three iOSVersion enums and the iOSDevice enum, confirming the committed types were otherwise in sync. Note the pre-existing drift in EiOSDevices, left alone here: it still carries iphone-14-pro and iphone-15-pro, which the API dropped. Worth its own cleanup rather than riding along with a feature change.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors devicecloud-dev/dcd, where iOS 27 and iphone-17/-pro/-pro-max ship behind the IOS_27 rollout gate (on for dev, off in production until the fleet carries a 27 runtime).
Nothing here needs gating. The flag descriptions and
cloud.tsvalidation derive from these enums, so the CLI offers the values and the API's compatibility matrix is what actually accepts or rejects them — a user who asks for iOS 27 against production gets "iOS version '27' is not supported for device ...", which is the right error.src/utils/compatibility.tsalready fetches the live matrix from GET /results/compatibility/data, sodcd list devicestracks the gate without a release.schema.types.ts regenerated from the API's swagger.json; the only delta is the three iOSVersion enums and the iOSDevice enum, confirming the committed types were otherwise in sync.
Note the pre-existing drift in EiOSDevices, left alone here: it still carries iphone-14-pro and iphone-15-pro, which the API dropped. Worth its own cleanup rather than riding along with a feature change.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test