-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1696: Fixed refactoring #1695
Draft
jan-vcapgemini
wants to merge
19
commits into
devonfw:config-reader-refactoring
Choose a base branch
from
jan-vcapgemini:config-reader-refactoring
base: config-reader-refactoring
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
#1696: Fixed refactoring #1695
jan-vcapgemini
wants to merge
19
commits into
devonfw:config-reader-refactoring
from
jan-vcapgemini:config-reader-refactoring
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed deserializer of read method in TemplatesConfigurationReader fixed GenerationProcessor fixed TemplatesConfigurationReaderTest fixed TemplateSetReaderTest fixed TemplateClassTest
replaced systemlambda with new setCobigenHomePath method
replaced systemlambda with new setCobigenHomePath method
added Maven path to template set path
github-actions
bot
added
comp:core
Team_CobiGen_Templates
These issues will be handeled by the team CobiGen_Templates
labels
Aug 7, 2023
replaced try-with-resource InputStream with URL added missing exception
added extra condition for jar handling to TemplateSetReader constructor
added exception when template set is empty
fixed valid template set file (made sure that all 3 templates can be read)
added latest version to Context and TemplatesConfigurationVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:eclipse
comp:core
Team_CobiGen_Templates
These issues will be handeled by the team CobiGen_Templates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses/Fixes #1696 .
Implements
@devonfw/cobigen