Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devonfw/IDEasy#631: Removed obsolete files #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fahamzaoui thanks for your PR. 👍
all done as specified in devonfw/IDEasy#631
What I am not 100% sure is that we delete Default.xml since devonfw/IDEasy#632 is not (yet) implemented. Also some projects might still like to configure the default code style this way.
However, we have seen that the .editorconfig is the best-practice and the way to go.
Keeping the XML configuration could quickly lead to confusion and inconsistency if out of sync with the .editorconfig.
Therefore, I will merge and we then have to push forward that the .editorconfig is actually applied to the workspace automatically by IDEasy.

@hohwille
Copy link
Member

license/cla Pending — Contributor License Agreement is not signed yet.

Too bad. IMHO this does not make so much sense if @fahamzaoui already left the project.
@jan-vcapgemini if we cannot get the CLA, you might redo the PR or how can we proceed?
I cannot bypass this rule since it is a legal requirement. Sorry.

@jan-vcapgemini
Copy link
Contributor

license/cla Pending — Contributor License Agreement is not signed yet.

Too bad. IMHO this does not make so much sense if @fahamzaoui already left the project. @jan-vcapgemini if we cannot get the CLA, you might redo the PR or how can we proceed? I cannot bypass this rule since it is a legal requirement. Sorry.

I've refreshed the CLA. Seems to work now. We've tried to make sure that this is fixed, but seems to be buggy when using force pushes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Remove obsolete intellij configuration files from settings
4 participants