Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #1942

Open
wants to merge 11 commits into
base: caio-test
Choose a base branch
from
Open

test #1942

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/exercises-reviewer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,14 @@ on:
pull_request:
paths:
- 'students/**/*'
env:
EXERCISE: git04

jobs:
git04:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
- uses: actions/checkout@v2
- uses: actions/setup-python@v4

- name: Review
run: make review REVIEW_EXERCISE=${{ EXERCISE }}
run: python ./exercises/git04/review.py

5 changes: 2 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@ export BRANCH_NAME?=
export FOLDER_NAME?=
RUNNER = docker-compose run --rm
TF_VAR_github_token?=
EXERCISES_PATH?=exercises
REVIEW_EXERCISE?=

ROOT_DIR:=$(shell dirname $(realpath $(firstword $(MAKEFILE_LIST))))

Expand All @@ -16,7 +14,8 @@ dashboard:
$(RUNNER) aws-cli /app/scripts/dashboard/publish.sh

review:
$(RUNNER) review /app/${EXERCISES_PATH}/${REVIEW_SCRIPT}/review.py
ls
$(RUNNER) review /app/review.py

presentation:
docker-compose up -d
Expand Down
3 changes: 2 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ services:
- GH_USER
- GH_TOKEN
review:
build: ./scripts/review
build: ./exercises
volumes:
- ${PWD}:/app
environment:
- GH_USER
- GH_TOKEN
- EXERCISE
aws-cli:
image: amazon/aws-cli
volumes:
Expand Down
8 changes: 1 addition & 7 deletions exercises/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
FROM python:3
# RUN python3 review.py

# Copies your code file from your action repository to the filesystem path `/` of the container
COPY entrypoint.sh /entrypoint.sh

# Code file to execute when the docker container starts up (`entrypoint.sh`)
ENTRYPOINT ["/entrypoint.sh"]
COPY $EXERCISE/review.py review.py
# RUN pip3 install gspread numpy pandas matplotlib
# RUN apt-get update -y
# RUN apt-get install -y jq
11 changes: 0 additions & 11 deletions exercises/git04/action.yaml

This file was deleted.

3 changes: 0 additions & 3 deletions exercises/git04/entrypoint.sh

This file was deleted.

Empty file removed exercises/git04/stage1.py
Empty file.
4 changes: 0 additions & 4 deletions scripts/review/Dockerfile

This file was deleted.

5 changes: 5 additions & 0 deletions students/caiocezart/exercises/git04/my_env.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
test