Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ai fetch and remove types from this package #53

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cfortuner
Copy link

@cfortuner cfortuner commented Oct 25, 2024

Updates this package to use https://github.com/dexaai/ai-fetch

As such, this pr now reexports the core types from ai-fetch.

NOTE: need to publish ai-fetch before we can update the package json here.

Copy link
Collaborator

@rileytomasek rileytomasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's exciting to see this happening ✨.

if ai-fetch is going to export the full openai-based types, shouldn't we be able to use them directly in the openai-client and delete openai-types/* and the openai dependency from this package? the current way feels duplicative, will run into issue matching type versions, and uses the openai package types directly instead of openai-types/*, which will risk bundler issues with the gnarly openai package.

@rileytomasek
Copy link
Collaborator

also, added @transitive-bullshit to the reviewers :)

@transitive-bullshit
Copy link
Collaborator

this seems to complicate things quite a bit; when the whole reason openai-fetch exists is to simplify the openai package.

if we're going with this route, I'd prefer a monorepo for ai-fetch + *-fetch since changes across one will likely necessitate changes across each of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants