Skip to content

Commit

Permalink
Update Node version for darwin to latest v14 to match the one for Linux
Browse files Browse the repository at this point in the history
The Node version installed in provision-darwin.sh is different from the one in provision-linux.sh. In provision-linux.sh the latest v14 is installed, which is v14.21.3.

This is to prevent errors like the following when upgrading some node modules:
```
Error: Cannot find module 'node:process'
Require stack:
- /Users/runner/work/examples/examples/motoko/encrypted-notes-dapp/node_modules/rollup/dist/bin/rollup
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:880:15)
    at Function.Module._load (internal/modules/cjs/loader.js:725:27)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Module.<anonymous> (/Users/runner/work/examples/examples/motoko/encrypted-notes-dapp/node_modules/rollup/dist/bin/rollup:16:19)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/runner/work/examples/examples/motoko/encrypted-notes-dapp/node_modules/rollup/dist/bin/rollup'
  ]
}
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! encrypted-notes-dapp@0.2.0 build: `rollup -c --bundleConfigAsCjs`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the encrypted-notes-dapp@0.2.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/runner/.npm/_logs/2023-07-07T21_24_41_174Z-debug.log
```
  • Loading branch information
fspreiss authored Jul 8, 2023
1 parent 75c655b commit 2391e90
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/provision-darwin.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ bash install-brew.sh
rm install-brew.sh

# Install Node.
version=14.15.4
version=14.21.3
curl --location --output node.pkg "https://nodejs.org/dist/v$version/node-v$version.pkg"
sudo installer -pkg node.pkg -store -target /
rm node.pkg
Expand Down

0 comments on commit 2391e90

Please sign in to comment.