Add llvm with wasm32-unknown-unknown as requirement to rust basic bitcoin
#1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspreiss
approved these changes
Oct 11, 2024
| @@ -27,6 +27,9 @@ For a deeper understanding of the ICP < > BTC integration, see the [Bitcoin inte | |||
| SDK](https://internetcomputer.org/docs/current/developer-docs/setup/install/index.mdx). | |||
| For local testing, `dfx >= 0.22.0-beta.0` is required. | |||
|
|
|||
| On Mac, `llvm` with the `wasm32-unknown-unknown` target (which is not included in the XCode installation by default) is required. | |||
There was a problem hiding this comment.
Given that the other prerequisite is itemized with a bullet and a checkbox (* [x]), this note here about macOS is not so prominent so my impression is it could easily be overlooked. So I suggest to make this
* [x] On macOS, llvm with...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
llvmwithwasm32-unknown-unknownis not installed, the compilation would error with something similar toSee rust-bitcoin/rust-bitcoin#2331 for more details.