Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the basic Bitcoin example #616

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

THLO
Copy link
Contributor

@THLO THLO commented Sep 15, 2023

The PR polishes and fixes a few minor things in the basic Bitcoin example:

  • Renamed variables to indicate that fees are measured in sat/vbyte (and not sat/byte).
  • Introduced a transaction_id type as the return value for the send function.
  • Introduced the SIGN_WITH_ECDSA_COST_CYCLES constant.
  • Fixed the index for the median fee (the median fee is at index 50 and not 49).
  • Reshuffled some comments and code.

@THLO THLO requested a review from a team as a code owner September 15, 2023 07:31
@sesi200 sesi200 merged commit 89f44ad into master Sep 25, 2023
69 checks passed
@sesi200 sesi200 deleted the tl/polish_basic_bitcoin branch September 25, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants