Skip to content

Commit

Permalink
build: agent-js v1.2.1 (#593)
Browse files Browse the repository at this point in the history
# Motivation

The migration to  pure JS BLS verification in agent-js v1.2.0 has a notable impact on bundle size (roughly -15% according [forum post](https://forum.dfinity.org/t/agent-js-1-2-0-is-released/28881/2?u=peterparker)). Therefore it makes sense to promote those changes.

# Notes

To prevent the issue reported on the [forum](https://forum.dfinity.org/t/timestamp-failed-to-pass-the-watermark-after-retrying-the-configured-3-times/29180/3?u=peterparker) to happen, the number of retry for the agent has been set to 10 similiar has what was done in II (see [PR](dfinity/internet-identity#2446))

# Changes

- `npm run update:agent`
- set number of retry to 10 and expose a parameter to tweak the value if required
  • Loading branch information
peterpeterparker authored Apr 29, 2024
1 parent ddae7f2 commit b1d8555
Show file tree
Hide file tree
Showing 13 changed files with 102 additions and 95 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@
- Add support for `withdrawErc20`.
- Additional fields related to ERC20 have been added to ckETH `minterInfo`.
- Expose the function `ledger_id` for Index canister in the `ledger-icrc` library.
- Set number of retries to 10 (as opposed to default 3) in `createAgent` utility to make the agent more resilient against watermark check failures.

## Build

- Upgrade `agent-js` dependencies to `v1.2.1`. Note that it is advised to set the number of retries of the agent to 10 to prevent the potential issue `Timestamp failed to pass the watermark after retrying the configured 3 times. We cannot guarantee the integrity of the response since it could be a replay attack.` (see thread on the [forum](https://forum.dfinity.org/t/timestamp-failed-to-pass-the-watermark-after-retrying-the-configured-3-times/29180/3?u=peterparker)).
- Upgrade `didc` to `0.3.7` that converts candid files into JS and TS.

# 2024.03.25-1430Z
Expand Down
128 changes: 64 additions & 64 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/ckbtc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
},
"dependencies": {
Expand Down
6 changes: 3 additions & 3 deletions packages/cketh/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/cmc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/ic-management/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/ledger-icp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/ledger-icrc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
],
"homepage": "https://github.com/dfinity/ic-js#readme",
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/nns/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@
"network-nervous-system"
],
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/ledger-icp": "^2.2.2",
"@dfinity/principal": "^1.0.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
}
}
6 changes: 3 additions & 3 deletions packages/sns/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@
"sns"
],
"peerDependencies": {
"@dfinity/agent": "^1.0.1",
"@dfinity/candid": "^1.0.1",
"@dfinity/agent": "^1.2.1",
"@dfinity/candid": "^1.2.1",
"@dfinity/ledger-icrc": "^2.2.1",
"@dfinity/principal": "^1.0.1",
"@dfinity/principal": "^1.2.1",
"@dfinity/utils": "^2.1.3"
},
"dependencies": {
Expand Down
Loading

0 comments on commit b1d8555

Please sign in to comment.