chore(IDX): rename test_utils bazel targets to their unique crate names #2136
+389
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ethereum/cketh/test_utils:ic_cketh_test_utils
…st_utils:ic_btc_adapter_test_utils
…l_state/tree_hash/test_utils:ic_canonical_state_tree_hash_test_utils
…st_utils:ic_rosetta_test_utils
…test_utils:ic_ledger_test_utils
basvandijk
changed the title
…test_utils:ic_crypto_tree_hash_test_utils
…rc1/test_utils:ic_icrc1_test_utils
…em/common/test_utils:ic_nervous_system_common_test_utils
…/ethereum/ledger-suite-orchestrator/test_utils:ic_ledger_suite_orchestrator_test_utils
… -> //rs/crypto/internal/crypto_lib/basic_sig/iccsa/test_utils:ic_crypto_internal_basic_sig_iccsa_test_utils
…est_utils -> //rs/rosetta-api/icp/ledger_canister_blocks_synchronizer/test_utils:ic_ledger_canister_blocks_synchronizer_test_utils
…test_utils:test_utils -> //rs/crypto/internal/crypto_lib/threshold_sig/canister_threshold_sig/test_utils:ic_crypto_internal_threshold_sig_canister_threshold_sig_test_utils
github-actions
bot
added
@ic-message-routing-owners
@finint
@networking
@cross-chain-team
labels
mraszyk
approved these changes
Oct 19, 2024
altkdf
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many bazel targets named
test_utils. This has the problem that when looking at critical path statistics like:it's hard to know which
test_utilstarget is being referenced making it harder to know which crate to optimise.The crates targeted by these
test_utilstargets do have unique names. I therefor propose to rename thetest_utilstargets to the crates they target.I propose the same for other targets like
utilsandcommon.