Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable option to default select first service point if none is selected #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rakibabu
Copy link

@rakibabu rakibabu commented Feb 12, 2024

Hi,

For some countries, additional information is required. Two examples of these countries are Germany and Luxembourg. People here rent a service point box with a number, the so-called Post numbers.

Since you automatically select a service point at the API endpoint and do not have validation on this postal number, we are now receiving many complaints about orders without a postal number.

To prevent this, I have created a configurable option per store that can be turned on or off, so that the respective countries always need to select a service point themselves during checkout.

This ensures that the validation is now correct again, as a mandatory postal number must be filled in within the service point modal itself.

Hopefully, you can merge this code contribution quickly :)

Greetings,

Rakibabu

@dennisvanderhammen-devnl
Copy link
Contributor

Hi @rakibabu,

Thank you for explaining your issue and providing a pull request.

I've communicated this with our team and we came to the conclusion that what you are explaining seems to be a bug. The auto-selection should provide a postal number.

I'll create an issue on our backlog to solve the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants