Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:picker、scroll、slide component cannot scroll on some kind of pc de… #398

Open
wants to merge 1,002 commits into
base: dev
Choose a base branch
from

Conversation

duoremix
Copy link

This pull request is for solving the issue #397.

In the code of picker、scroll、slide component, I set the configure of "disableMouse" to "false", which is the configure of better-scroll. This change is to solving problem that those components cannot be use on some PC devices, which have touch event on the window object.

dolymood and others added 28 commits November 20, 2018 20:56
* feat: max

* test(time-picker): max example

* fix(time-picker): days.len

* docs: max

* fix(time-picker): column init

* test(time-picker): max

* docs: max

* test: fix minute step

* fix: potential float bug

* feat(time-picker): min

* test(time-picker): min

* docs(time-picker): min

* docs(time-picker): min, max
* chore: update scroll example's img

* chore: replace img links
* fix(slide): goToPage direction

* fix: remove default time value in goToPage function
@codecov-io
Copy link

codecov-io commented Jan 23, 2019

Codecov Report

Merging #398 into dev will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #398     +/-   ##
=========================================
- Coverage   92.77%   92.68%   -0.1%     
=========================================
  Files         141      138      -3     
  Lines        3074     2965    -109     
  Branches      498      489      -9     
=========================================
- Hits         2852     2748    -104     
+ Misses        117      108      -9     
- Partials      105      109      +4
Impacted Files Coverage Δ
src/components/recycle-list/recycle-list.vue 90.66% <0%> (-7.4%) ⬇️
src/components/radio/radio-group.vue 87.5% <0%> (-1.39%) ⬇️
src/components/image-preview/image-preview.vue 92.5% <0%> (-1.25%) ⬇️
src/components/form/form.vue 93.02% <0%> (-1.14%) ⬇️
src/components/upload/file.vue 84.21% <0%> (-0.79%) ⬇️
src/components/picker/picker.vue 82.45% <0%> (-0.45%) ⬇️
src/components/date-picker/date-picker.vue 98.73% <0%> (-0.02%) ⬇️
src/components/cascade-picker/cascade-picker.vue 81.81% <0%> (ø) ⬆️
src/components/checkbox-group/checkbox-group.vue 100% <0%> (ø) ⬆️
src/components/textarea/textarea.vue 92% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60b761a...0847638. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants