Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try building wheels with CI for pdffit2 #93

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Oct 4, 2024

This is only for exhibition purposes for a cpython package. Final changes should be done on release-script

Copy link

github-actions bot commented Oct 4, 2024

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix,
please add a news item by copying the format from news/TEMPLATE.rst.

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Oct 4, 2024

need to change something with linux

@Tieqiong Tieqiong marked this pull request as draft October 4, 2024 04:15
@Tieqiong
Copy link
Contributor Author

Tieqiong commented Oct 4, 2024

windows still producing wheels that lack proper dll. It seems like the problem is not about installing with conda or vcpkg

@sbillinge
Copy link
Contributor

thanks for the hard work on this @Tieqiong

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Oct 7, 2024

@sbillinge

Very weird. It was giving that dll error on Friday but when I randomly try it again it's working. It would be nice if we can test the windows wheel on your machine. You can grab it by going into the wheel builder action job (windows-latest with the right python version) and there will be a GitHub link under Run actions/upload-artifact@v4. Download the file and run pip install diffpy.pdffit2-0.0.1-cp312-cp312-win_amd64.whl (taking the py3.12 one as example), then conda install pytest and pytest. Thanks

otherwise the Mac (arm version, don't have an intel m1 to test on) and linux wheels are good

@Tieqiong
Copy link
Contributor Author

Tieqiong commented Oct 7, 2024

Tested with a windows VM and it's still showing the error. Will figure it out

@Tieqiong Tieqiong closed this Oct 7, 2024
@Tieqiong Tieqiong deleted the wheel branch October 7, 2024 21:52
@Tieqiong Tieqiong restored the wheel branch October 7, 2024 21:55
@Tieqiong Tieqiong reopened this Oct 7, 2024
@Tieqiong
Copy link
Contributor Author

Tieqiong commented Oct 8, 2024

This is ready, just need someone test the wheel for Intel Mac (intel M1, using the macOS-13 wheel).

Tested arm Mac on M2, linux on ubuntu 24.04, Windows on Windows_Server-2022.

@sbillinge
Copy link
Contributor

great news @Tieqiong !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants