Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matplotlib instead of matplotlib-base in run.txt - discussion on assign packages #220

Closed
wants to merge 3 commits into from

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Oct 2, 2024

The latest rc version of pdfgui contains run.txt which contains matplotlib-base.

This PR fixes the following:

pip install diffpy.pdfgui==3.1.0rc5

ERROR: Could not find a version that satisfies the requirement matplotlib-base (from diffpy-pdfgui) (from versions: none)
ERROR: No matching distribution found for matplotlib-base

Closes #207 - tested that run.txt dependencies are installed during pip install.

@bobleesj bobleesj marked this pull request as ready for review October 2, 2024 13:26
@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 2, 2024

@sbillinge ready for review

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 2, 2024

@sbillinge will make a new general PR based on today's discussion

  • conda.txt for all conda dependencies for our CI to run conda install --file requirements/...
  • pip.txt for all pip dependencies required for pip install <package>

@bobleesj bobleesj closed this Oct 2, 2024
@sbillinge
Copy link
Contributor

I am afraid this means we will have to update all documentation and readmes as well. Not sure if it is more work to share this around or just do it. In general, it might be good to assigne packages to people, and whenever there is a task like this, we send a general slack saying "please update your packages by Friday" and everyone knows what it means. We will have to assign packages to new people when old people leave....

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 2, 2024

@sbillinge Indeed, these are the current chefs now:

  • diffpy.pdfmorph | Andrew
  • diffpy.srmise | Steven
  • diffpy.labpdfproc | Yucong
  • diffpy.fourigui | Caden
  • diffpy.utils |
  • diffpy.structure |
  • diffpy.pdfgui |
  • diffpy.srfit |
  • diffpy.snmf |
  • bg-mpl-stylesheets |
  • †diffpy.pdffit2 |
  • †diffpy.srreal |
  • diffpy.nmf_mapping |

Next week, perhaps we can sit down and assign each member have 2 packages (also include Tieqiong) and also have new members take on one or two for training as well?

@bobleesj bobleesj changed the title Use matplotlib instead of matplotlib-base in run.txt Use matplotlib instead of matplotlib-base in run.txt - discussion on assign packages Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check dependency installation section in pyproject.toml
2 participants