Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove importable package warnings during python -m build, use conda.txt instead of pip.txt #223

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Remove importable package warnings during python -m build, use conda.txt instead of pip.txt #223

merged 3 commits into from
Oct 3, 2024

Conversation

bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Oct 2, 2024

Closes #219

@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 2, 2024 •
edited
Loading

@sbillinge ready for review - CI will fail since the conda.txt is used instead of run.txt. Once Billingegroup/release-scripts#58 is merged and its v0 is merged from main. The CI will most likely pass.

@sbillinge
Copy link
Contributor

rerunning CI test after merging the new release-scripts worfklow PR into v0

@sbillinge
Copy link
Contributor

merging, all tests pass now.

@sbillinge sbillinge merged commit 33194a0 into diffpy:main Oct 3, 2024
3 checks passed
@bobleesj bobleesj deleted the build-warning branch October 3, 2024 02:08
@bobleesj
Copy link
Contributor Author

bobleesj commented Oct 3, 2024

great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove importable package warnings during python -m build
2 participants
@bobleesj @sbillinge