-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use meshloader to support multiple file formats loading #744
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Tin Lai <tin@tinyiu.com>
//! - Mesh file types other than `stl` are not supported yet. Contributions are welcome. You my check the `rapier3d-stl` | ||
//! - Mesh file types are limited. Contributions are welcome. You may check the `rapier3d-meshloader` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about what other types urdf could support 🤔
/// - `converter`: controls how the shapes are computed from the content. In particular, it lets | ||
/// you specify if the computed [`SharedShape`] is a triangle mesh, its convex hull, | ||
/// bounding box, etc. | ||
// TODO: call a function for each mesh to load ? To be able to have a different mesh converter? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
open question 💭
//! `stl`: support .stl files | ||
//! `collada`: support .dae files | ||
//! `wavefront`: support .obj files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a huge fan of listing features here, it sounds like an easy thing to forget when changing features, I'd be more comfortable with an include of the readme.md here 🤔 ?
mesh-loader
is added to a more generic crate.CHANGELOG.md
for a list of changesrapier/crates/rapier3d-meshloader/CHANGELOG.md
Lines 1 to 13 in fb8a7c7