This repository has been archived by the owner on Dec 24, 2021. It is now read-only.
DurationArgumentType #256
Open
DurationArgumentType #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahsnider
suggested changes
Apr 1, 2019
|
I'll make those changes. None of these popped up from |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#182 Added Duration type.
Takes a string in this format:
1mo2w3d4h5m6s7msor1mo 2w 3d 4h 5m 6s 7ms.The issue mentioned having methods for this type but I don't believe they can be accessed. If I'm wrong about that, it would be a quick to add them back in.