BCIR-246 : Refactor islandora_entity_status - Events #7
Conversation
Sync with main branch
Change Markup class
| /** | ||
| * Defines an event subscriber for Islandora Media. | ||
| */ | ||
| class IslandoraNodeEntitySubscriber implements EventSubscriberInterface { |
There was a problem hiding this comment.
Just for convention purposes, shouldn't this be named IslandoraNodeEventSubscriber instead?
There was a problem hiding this comment.
Changed to IslandoraNodeEventSubscriber
| foreach ($results as $result) { | ||
| $processed_nodes_message .= $result . '<br>'; | ||
| } | ||
| $messenger->addMessage(new Markup($processed_nodes_message, 'html')); |
There was a problem hiding this comment.
Should we be using Markup here? Would a render array be preferred?
We could instead add the node messages to a list:
$messages = [];
foreach ($results as $result) {
$messages[] = $result;
}
$message = [
'#theme' => 'item_list',
'#items' => $messages,
'#title' => $this->t('Processed Nodes'),
];
$this->messenger->addMessage(\Drupal::service('renderer')->renderRoot($message));There was a problem hiding this comment.
Agree, changed to render array.
| protected $messenger; | ||
|
|
||
| /** | ||
| * Constructs a new IslandoraMediaSubscriber object. |
There was a problem hiding this comment.
Assuming this is just a copypasta error, should be IslandoraNodeEventSubscriber / IslandoraNodeEntitySubscriber (depending on what the name ends up being)
There was a problem hiding this comment.
Changed to IslandoraNodeEventSubscriber
| /** | ||
| * Defines an event subscriber for Islandora Media. | ||
| */ | ||
| class IslandoraMediaEntitySubscriber implements EventSubscriberInterface { |
There was a problem hiding this comment.
Should be IslandoraMediaEventSubscriber right?
There was a problem hiding this comment.
Changed to IslandoraMediaEventSubscriber
No description provided.