[DDST-54] add node_list and media_list cache tags #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this, manifests made from child nodes don't always get updated when new child nodes are added.
Suggested by adam-vessey, and I think this matches the cache api expectations more closely than messing about with getting the 'cacheability' element of the context array.
In cases where the media entities get deleted and new ones get added, there is nothing about the cache dependency on the old media entities or the node entities that would get updated when new media entities get added that reference the relevant node.
If it's added only when there is attached media, then the normalization that's triggered after media is deleted ends up not getting told to update when new media is added.
JojoVes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the node_list cache tag, manifests made from child nodes don't always get updated when new child nodes are added.
Without the media_list cache tag, manifests that get updated after a referenced media is deleted don't always get updated when a new relevant media entity gets added.
The common ground for both of these points is that the entity references involved are one-way: the media references the node, and the child node references the parent node. So, if an environment has other code to trigger updates for entities when they get referenced by other entities then this would not be an issue in that case, since the referenced entities are accounted for as cache dependencies already.