On v3, please provide only secret_key OR public_key. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Providing both leads to trouble. See: https://groups.google.com/d/msg/disqus-dev/9HBAftO0jr0/gD_j-rWdSqsJ
| @@ -162,8 +162,8 @@ class DisqusAPI(Resource): | |||
| def __init__(self, secret_key=None, public_key=None, format='json', version='3.0', **kwargs): | |||
| self.secret_key = secret_key | |||
| self.public_key = public_key | |||
| if not public_key: | |||
| warnings.warn('You should pass ``public_key`` in addition to your secret key.') | |||
| if secret_key and public_key: | |||
There was a problem hiding this comment.
Well, this doesn't warn them if they omit both. Not sure if it is necessary, just pointing out.
There was a problem hiding this comment.
You are right.
I cannot find out an entrypoint that does not require at least the public_key, but here is said that Disqus "recommend using SSL for all requests to the API, but it is not required for anonymous requests.".
Question is: what "anonymous requests" means? If nothing can be hit without public or secret key, is safe to raise an exception for this case.
If someone can confirm that, I will happily update the PR to raise an exception for no key provided, or at least put one more warning.
mattrobenolt
force-pushed
the
master
branch
2 times, most recently
from
0ba26c4
to
ae338e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing
public_keyANDsecret_keyleads to trouble.See: https://groups.google.com/d/msg/disqus-dev/9HBAftO0jr0/gD_j-rWdSqsJ
Question: should we get rid of public_key mentions on the whole codebase?