Python3 support needed #33
Open
+393
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It provides a nice overview of the tweaks which we see in the codebase, so that it supports both Python2 and Python3.
Background idea is that we use string types as switch names and if we do this consistently, then the keys can be encoded into bytes objects. At least the RedisDict as storage will otherwise happily take str instances and return bytes instances. Result is that the Manager cannot find the switches anymore and we see issues due to mixing up str and bytes.
__cmp__ is ignored and cmp() is gone. Only one way left to compare.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14 (comment)