Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugzilla 24592 - ImportC: Bitfield layout wrong for int64 on 32-b… #16590

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

tim-dlang
Copy link
Contributor

…it Linux

Type ulong is 64-bit on 32-bit Linux, but has 32-bit alignment. This affects the layout of bitfields.

Also add a new test for ImportC bitfields, which compares size, alignment and layout with the host C++ compiler. The existing tests compared with fixed values instead.

…it Linux

Type ulong is 64-bit on 32-bit Linux, but has 32-bit alignment.
This affects the layout of bitfields.

Also add a new test for ImportC bitfields, which compares size,
alignment and layout with the host C++ compiler. The existing
tests compared with fixed values instead.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @tim-dlang! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24592 normal ImportC: Bitfield layout wrong for int64 on 32-bit Linux

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16590"

@dlang-bot dlang-bot merged commit 4c82050 into dlang:master Jun 17, 2024
41 checks passed
@tim-dlang tim-dlang deleted the issue24592 branch June 17, 2024 16:49
@kinke
Copy link
Contributor

kinke commented Jul 19, 2024

Thanks a lot man for these real tests! They have uncovered an apparent AArch64-specific special case (except for Apple targets), see ldc-developers/ldc#4707 (comment) and following.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants