-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[distGB] change test_mp_dataloader #7819
base: master
Are you sure you want to change the base?
Conversation
To trigger regression tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you run all tests under /tests/distributed/
in your local manually? as CI does not run them.
python/dgl/distributed/partition.py
Outdated
config_path, f"part{part_id}", "fused_csc_sampling_graph.pt" | ||
) | ||
): | ||
use_graphbolt = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may violate user's intent if both graph.dgl
and fused_xxx.pt
exists. As the existence of both of them is a previous result and it should not happen since now, so it's acceptable here. but in case, let's just crash here if this case happens, just ask user to remove one of them.
fix the bug in test_mp_dataloader.py when use graphbolt.
the pr is related to issue #7815