[distGB]fix the problem when graph has few nodes or edges in distributed partition #7824
+284
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
Rhett-Ying
reviewed
Oct 14, 2024
| @@ -355,6 +356,33 @@ def _process_partition_gb( | |||
| return indptr, indices[sorted_idx], edge_ids[sorted_idx] | |||
|
|
|||
|
|
|||
| def update_node_map(node_map_val, end_ids_per_rank, id_ntypes, prev_last_id): | |||
There was a problem hiding this comment.
copied from partition.py or modified accordingly? please add a comment to clarify it
| next_table = pyarrow.Table.from_batches([next_chunk]) | ||
| src_ids.append(next_table["f0"].to_numpy()) | ||
| dst_ids.append(next_table["f1"].to_numpy()) | ||
| if os.path.getsize(edge_file) != 0: |
There was a problem hiding this comment.
what if size == 0? add a comment here to clarify it.
if getsize() == 0: blabla... continue is better, I think.
added 2 commits
October 15, 2024 01:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr fix the issue related to #7793. When the number of nodes or edges is less than the number of partitions, partition can be created normally.