patches php 81

[mashb1t]

Hey @schmunk42 / @handcode,

we made the code compatible with PHP8.1. It would be great if you could review and merge the changes if you're fine with the adjustments.

[handcode]

Hi @mashb1t,

maybe I missed something (just a quick review), but what exactly 'made the code compatible with PHP8.1'?

beside that:
the empty() checks looks ok, we have to look closer at the exception handling, but it should also fit.

But what IMHO is not acceptable is the last commit 14c3e6f. This way the module can't be included anymore under another name than the one from Module::NAME, or several times with different config.

PS: it would be nice to separate formatting from functional changes in commits. Makes the process much clearer and easier for reviewers.

Cc: @eluhr

[boehmi1988]

Hi @handcode

just to be clear: the changes do not claim to establish full 8.1 compatibility of the project - we just fixed some issues we had in our implementation when lifting it up to 8.1 - there still might be some incompatibilities left in other parts of the code we do not use.

In our case it was mostly adding the null/empty checks as of 8.1 functions like ltrim & str_replace do not support null as a parameter any longer and in some cases the parent functions were called with null parameters causing exceptions when running under php 8.1.

You're right about your concerns about 14c3e6f - i did another implementation with several fallbacks in cad1f1d where it uses the name only as a last resort when getting the module from the loadedModules map or the controller failes. I hope that's acceptable