Fix code highlighting bug #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in Dolos the feature to highlight which fragments are matched in the Matches view is broken. This is due to a small bug in the corresponding code which checks if the hovering/selected match is equal to the match whose decoration we are supposed to be changing.
This PR changes how the equivalence is checked from the JS === to a small helper function called "areMatchesEqual" which checks that two matches have the same values.
Feel free to suggest other solutions to this bug, but this seems to work quite well. I also changed the alpha value of the selected match to be less transparent.
Related issue: #1588